Use :mode instead of :redraw! when updating menu. (#1016 )

* Use :mode instead of :redraw! when updating screen. In neovim, it will actually clear the whole screen, whereas, redraw! does not. * Update version number in change log.
When searching for root line num, stop at the end of the file. (#1015 )
2025-11-08 19:33:50 -05:00 · 2019-07-07 03:19:17 -04:00 · 2019-07-04 00:21:50 -04:00 · 2019-07-03 11:12:21 -04:00 · 2019-07-03 11:11:25 -04:00 · 2019-07-02 15:45:36 -04:00
5 changed files with 10 additions and 6 deletions
--- a/.github/ISSUE_TEMPLATE/bug.md
+++ b/.github/ISSUE_TEMPLATE/bug.md
@@ -22,9 +22,8 @@ After reading, and before submitting your issue, please remove this introductory

 #### Environment (for bug reports)
 - [ ] Operating System: 
- [ ] Vim/Neovim version `:version`: 
- [ ] NERDTree version `:echo nerdtree#version(0)` or `git rev-parse --short HEAD`: 
- [ ] A link to my [vimrc](), or
+- [ ] Vim/Neovim version `:echo v:version`: 
+- [ ] NERDTree version, found on 1st line in NERDTree quickhelp `?`: 
 - [ ] vimrc settings
    - [ ] NERDTree variables
    ```vim
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,10 @@
 # Change Log

 #### 5.2...
+- **.5**: Use `:mode` instead of `:redraw!` when updating menu. (PhilRunninger) #1016
+- **.4**: When searching for root line num, stop at end of file. (PhilRunninger) #1015
+- **.3**: Fix `<CR>` key map on the bookmark (lkebin) #1014
+- **.2**: Make Enter work on the `.. ( up a dir )` line (PhilRunninger) #1013
 - **.1**: Fix nerdtree#version() on Windows. (PhilRunninger) N/A
 - **.0**: Expand functionality of `<CR>` mapping. (PhilRunninger) #1011
 #### 5.1...
--- a/autoload/nerdtree/ui_glue.vim
+++ b/autoload/nerdtree/ui_glue.vim
@@ -17,6 +17,7 @@ function! nerdtree#ui_glue#createDefaultBindings()
    call NERDTreeAddKeyMap({ 'key': g:NERDTreeMapCustomOpen, 'scope':'FileNode', 'callback': s."customOpenFile"})
    call NERDTreeAddKeyMap({ 'key': g:NERDTreeMapCustomOpen, 'scope':'DirNode', 'callback': s."customOpenDir"})
    call NERDTreeAddKeyMap({ 'key': g:NERDTreeMapCustomOpen, 'scope':'Bookmark', 'callback': s."customOpenBookmark"})
+    call NERDTreeAddKeyMap({ 'key': g:NERDTreeMapCustomOpen, 'scope':'all', 'callback': s."activateAll" })

    call NERDTreeAddKeyMap({ 'key': g:NERDTreeMapActivateNode, 'scope': "DirNode", 'callback': s."activateDirNode" })
    call NERDTreeAddKeyMap({ 'key': g:NERDTreeMapActivateNode, 'scope': "FileNode", 'callback': s."activateFileNode" })
@@ -94,7 +95,7 @@ endfunction
 "FUNCTION: s:customOpenBookmark() {{{1
 " Open bookmark node with the "custom" key, initially <CR>.
 function! s:customOpenBookmark(node)
-    if node.isDirectory
+    if a:node.path.isDirectory
        call a:node.activate(b:NERDTree, s:initCustomOpenArgs().dir)
    else
        call a:node.activate(b:NERDTree, s:initCustomOpenArgs().file)
--- a/lib/nerdtree/menu_controller.vim
+++ b/lib/nerdtree/menu_controller.vim
@@ -31,7 +31,7 @@ function! s:MenuController.showMenu()
        let l:done = 0

        while !l:done
-            redraw!
+            mode
            call self._echoPrompt()

            let l:key = nr2char(getchar())
--- a/lib/nerdtree/ui.vim
+++ b/lib/nerdtree/ui.vim
@@ -254,7 +254,7 @@ endfunction
 " gets the line number of the root node
 function! s:UI.getRootLineNum()
    let rootLine = 1
-    while getline(rootLine) !~# '^\(/\|<\)'
+    while rootLine <= line('$') && getline(rootLine) !~# '^\(/\|<\)'
        let rootLine = rootLine + 1
    endwhile
    return rootLine
Author	SHA1	Message	Date
Phil Runninger	3b1a850b85	Use :mode instead of :redraw! when updating menu. (#1016 ) * Use :mode instead of :redraw! when updating screen. In neovim, it will actually clear the whole screen, whereas, redraw! does not. * Update version number in change log.	2019-07-07 03:19:17 -04:00
Phil Runninger	89a1a4355b	When searching for root line num, stop at the end of the file. (#1015 ) * When searching for root line num, stop at the end of the file. When using the following NERDTreeStatusLine, Vim would lock up and not work anymore. The problem was that when trying to find the root line number, the loop was continuing past the end of the file, looping "forever". The fix was to simply stop at the end of the file. let g:NERDTreeStatusline = "%{exists('g:NERDTreeFileNode')&&" . \ "has_key(g:NERDTreeFileNode.GetSelected(),'path')?" . \ "g:NERDTreeFileNode.GetSelected().path.getLastPathComponent(0):''}" * Update change log.	2019-07-04 00:21:50 -04:00
Phil Runninger	62b78de367	Update Change Log	2019-07-03 11:12:21 -04:00
Kebin Liu	aef6baf6e2	Update ui_glue.vim (#1014 ) Fix `<CR>` key map on the bookmark	2019-07-03 11:11:25 -04:00
Phil Runninger	06c9d9c963	Make Enter work on the `.. ( up a dir )` line (#1013 ) * Make Enter work on the `.. ( up a dir )` line. * Simpler instructions for getting bug info. * Update changelog.	2019-07-02 15:45:36 -04:00