Remove :silent from all :checktime uses

This can appear to hang with 'noautoread', or if the buffer has changed
in memory.  In reality it's not hanging, it's just silenced the
interactive prompt.

Resolves: https://github.com/tpope/vim-fugitive/issues/1917
This commit is contained in:
Tim Pope
2022-01-10 11:08:29 -05:00
parent 57968b63c2
commit fa20e5e77c

View File

@@ -3553,7 +3553,7 @@ function! s:RunBufDelete(bufnr) abort
if has_key(s:edit_jobs, a:bufnr) | if has_key(s:edit_jobs, a:bufnr) |
call add(s:resume_queue, remove(s:edit_jobs, a:bufnr)) call add(s:resume_queue, remove(s:edit_jobs, a:bufnr))
call feedkeys("\<C-\>\<C-N>:redraw!|call delete(" . string(s:resume_queue[-1][0].file . '.edit') . call feedkeys("\<C-\>\<C-N>:redraw!|call delete(" . string(s:resume_queue[-1][0].file . '.edit') .
\ ")|call fugitive#Resume()|silent checktime\r", 'n') \ ")|call fugitive#Resume()|checktime\r", 'n')
endif endif
endfunction endfunction
@@ -3828,7 +3828,7 @@ function! fugitive#Command(line1, line2, range, bang, mods, arg) abort
return (after_edit . after)[1:-1] return (after_edit . after)[1:-1]
endif endif
call add(s:resume_queue, [state, tmp, job]) call add(s:resume_queue, [state, tmp, job])
return 'call fugitive#Resume()|silent checktime' . after return 'call fugitive#Resume()|checktime' . after
elseif pager elseif pager
let pre = s:BuildEnvPrefix(env) let pre = s:BuildEnvPrefix(env)
try try
@@ -3877,7 +3877,7 @@ function! fugitive#Command(line1, line2, range, bang, mods, arg) abort
endif endif
endtry endtry
endif endif
return 'silent checktime' . after return 'checktime' . after
else else
return 'exe ' . string('noautocmd !' . escape(cmd, '!#%')) . after return 'exe ' . string('noautocmd !' . escape(cmd, '!#%')) . after
endif endif
@@ -6226,7 +6226,7 @@ function! fugitive#WriteCommand(line1, line2, range, bang, mods, arg, ...) abort
endfor endfor
endfor endfor
call fugitive#DidChange() call fugitive#DidChange()
return 'silent checktime' . after return 'checktime' . after
endfunction endfunction
function! fugitive#WqCommand(...) abort function! fugitive#WqCommand(...) abort