From 0a8ff7899c7d09457d3896fcce2d4dcffcc13e17 Mon Sep 17 00:00:00 2001 From: Junegunn Choi Date: Fri, 22 Aug 2025 19:13:30 +0900 Subject: [PATCH] Do not unset FZF_DEFAULT_* variables when using winpty Fix #4497 Fix #4400 --- src/proxy.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/proxy.go b/src/proxy.go index 958ae26f..590c6b68 100644 --- a/src/proxy.go +++ b/src/proxy.go @@ -90,11 +90,12 @@ func runProxy(commandPrefix string, cmdBuilder func(temp string, needBash bool) } } - // * Write the command to a temporary file and run it with sh to ensure POSIX compliance. - // * Nullify FZF_DEFAULT_* variables as tmux popup may inject them even when undefined. - exports := []string{"FZF_DEFAULT_COMMAND=", "FZF_DEFAULT_OPTS=", "FZF_DEFAULT_OPTS_FILE="} + // Write the command to a temporary file and run it with sh to ensure POSIX compliance. + var exports []string needBash := false if withExports { + // Nullify FZF_DEFAULT_* variables as tmux popup may inject them even when undefined. + exports = []string{"FZF_DEFAULT_COMMAND=", "FZF_DEFAULT_OPTS=", "FZF_DEFAULT_OPTS_FILE="} validIdentifier := regexp.MustCompile(`^[a-zA-Z_][a-zA-Z0-9_]*$`) for _, pairStr := range os.Environ() { pair := strings.SplitN(pairStr, "=", 2)