From 7bd99a22eeba74c88ad60f860111247a052f5586 Mon Sep 17 00:00:00 2001 From: Tomas Janousek Date: Fri, 13 Nov 2020 15:59:29 +0000 Subject: [PATCH] [bash-completion] Fix endless loop when completion.bash sourced twice I forgot to add the "not _fzf" check into __fzf_orig_completion, so invoking it twice would rewrite the _fzf_orig_completion_xxx variables and then cause an endless loop when completion is requested. Fixes: ef2c29d5d497 ("[bash-completion] Optimize __fzf_orig_completion_filter") --- shell/completion.bash | 1 + 1 file changed, 1 insertion(+) diff --git a/shell/completion.bash b/shell/completion.bash index 12baaf05..1eefd099 100644 --- a/shell/completion.bash +++ b/shell/completion.bash @@ -53,6 +53,7 @@ __fzf_orig_completion() { comp="${BASH_REMATCH[1]}" f="${BASH_REMATCH[2]}" cmd="${BASH_REMATCH[3]}" + [[ "$f" = _fzf_* ]] && continue printf -v "_fzf_orig_completion_${cmd//[^A-Za-z0-9_]/_}" "%s" "${comp} %s ${cmd} #${f}" if [[ "$l" = *" -o nospace "* ]] && [[ ! "$__fzf_nospace_commands" = *" $cmd "* ]]; then __fzf_nospace_commands="$__fzf_nospace_commands $cmd "