m/fzf
1
0
mirror of https://github.com/junegunn/fzf.git synced 2025-11-16 15:23:48 -05:00

Remove TODO comments

This commit is contained in:
Junegunn Choi
2025-09-28 23:50:26 +09:00
parent c87a8eccd4
commit 8a943a9b1a

View File

@@ -1124,7 +1124,6 @@ func NewTerminal(opts *Options, eventBox *util.EventBox, executor *util.Executor
if opts.GutterRaw != nil { if opts.GutterRaw != nil {
gutterRawChar = *opts.GutterRaw gutterRawChar = *opts.GutterRaw
} else if t.unicode && !t.theme.Gutter.Color.IsDefault() { } else if t.unicode && !t.theme.Gutter.Color.IsDefault() {
// TODO: Doesn't look too good. Maybe use a different color instead, or both?
gutterRawChar = "▖" gutterRawChar = "▖"
} else { } else {
gutterRawChar = ":" gutterRawChar = ":"
@@ -4814,10 +4813,6 @@ func (t *Terminal) selectItem(item *Item) bool {
if len(t.selected) >= t.multi { if len(t.selected) >= t.multi {
return false return false
} }
// TODO: Should we allow selecting non-matching items?
// if t.raw && !t.isItemMatch(item) {
// return false
// }
if _, found := t.selected[item.Index()]; found { if _, found := t.selected[item.Index()]; found {
return true return true
} }
@@ -6158,12 +6153,10 @@ func (t *Terminal) Loop() error {
case actAccept: case actAccept:
req(reqClose) req(reqClose)
case actAcceptNonEmpty: case actAcceptNonEmpty:
// TODO: Allow accepting unmatched items in raw mode?
if len(t.selected) > 0 || t.merger.Length() > 0 || !t.reading && t.count == 0 { if len(t.selected) > 0 || t.merger.Length() > 0 || !t.reading && t.count == 0 {
req(reqClose) req(reqClose)
} }
case actAcceptOrPrintQuery: case actAcceptOrPrintQuery:
// TODO: Allow accepting unmatched items in raw mode?
if len(t.selected) > 0 || t.merger.Length() > 0 { if len(t.selected) > 0 || t.merger.Length() > 0 {
req(reqClose) req(reqClose)
} else { } else {