v20141012

added instructions for deleting virtualenvs

README.md

@@ -114,6 +114,22 @@ You can also activate and deactivate a pyenv virtualenv this way:
     pyenv activate <name>
     pyenv deactivate
 
+
+### Delete existing virtualenv
+
+Removing the directory in `~/.pyenv/versions` will delete the virtualenv, or you can run:
+
+    pyenv uninstall my-virtual-env
+    
+
+### virtualenv and pyvenv
+
+There is [venv](http://docs.python.jp/3/library/venv.html) module available for CPython 3.3 and newer.
+It provides a command-line tool `pyvenv` which is the successor of `virtualenv` and distributed by default.
+
+The `pyenv-virtualenv` uses `pyvenv` if it is available and the `virtualenv` is not available.
+
+
 ### Special environment variables
 
 You can set certain environment variables to control the pyenv-virtualenv.
@@ -133,6 +149,12 @@ You can set certain environment variables to control the pyenv-virtualenv.
 
 ## Version History
 
+#### 20141012
+
+ * Fix warnings from `shellcheck` to improve support for POSIX sh (#40)
+ * Do not allow whitespace in `VIRTUALENV_NAME` (#44)
+ * Should not persist `PYENV_DEACTIVATE` after automatic deactivation (#47, #48)
+
 #### 20140705
 
  * Display information on auto-(de)?activation

bin/pyenv-sh-activate

@@ -112,7 +112,7 @@ EOS
   cat <<EOS
 unset PYENV_DEACTIVATE;
 export PYENV_ACTIVATE="${prefix}";
-source "${prefix}/bin/activate";
+. "${prefix}/bin/activate";
 EOS
   ;;
 esac

bin/pyenv-sh-deactivate

@@ -37,8 +37,10 @@ fish )
   ;;
 esac
 
+prefix="${PYENV_ACTIVATE:-${VIRTUAL_ENV}}"
+
 if [ -n "$VERBOSE" ]; then
-  echo "  echo \"pyenv-virtualenv: deactivate ${PYENV_ACTIVATE##*/}\" 1>&2;"
+  echo "  echo \"pyenv-virtualenv: deactivate ${prefix##*/}\" 1>&2;"
 fi
 
 if [ -z "${PYENV_VIRTUALENV_INIT}" ]; then
@@ -50,7 +52,7 @@ fi
 case "$shell" in
 fish )
   cat <<EOS
-  setenv PYENV_DEACTIVATE "$PYENV_ACTIVATE";
+  setenv PYENV_DEACTIVATE "$prefix";
   set -e PYENV_ACTIVATE;
   deactivate;
 else;
@@ -58,7 +60,7 @@ EOS
   ;;
 *    )
   cat <<EOS
-  export PYENV_DEACTIVATE="$PYENV_ACTIVATE";
+  export PYENV_DEACTIVATE="$prefix";
   unset PYENV_ACTIVATE;
   deactivate;
 else

bin/pyenv-virtualenv

@@ -9,7 +9,7 @@
 #   -f/--force       Install even if the version appears to be installed already
 #
 
-PYENV_VIRTUALENV_VERSION="20140705"
+PYENV_VIRTUALENV_VERSION="20141012"
 
 set -e
 [ -n "$PYENV_DEBUG" ] && set -x
@@ -297,6 +297,11 @@ if [ -z "${VERSION_NAME}" ] || [ -z "${VIRTUALENV_NAME}" ]; then
   usage 1
 fi
 
+if [ "$VIRTUALENV_NAME" != "${VIRTUALENV_NAME%[[:space:]]*}" ]; then
+  echo "pyenv-virtualenv: no whitespace allowed in virtualenv name." 1>&2
+  exit 1
+fi
+
 # Set VERSION_NAME as default version in this script
 export PYENV_VERSION="${VERSION_NAME}"
 

bin/pyenv-virtualenv-init

@@ -78,10 +78,12 @@ function _pyenv_virtualenv_hook --on-event fish_prompt;
   if [ -n "\$PYENV_ACTIVATE" ]
     if [ (pyenv version-name) = "system" ]
       pyenv deactivate --no-error --verbose
+      set -e PYENV_DEACTIVATE
       return 0
     end
     if [ "\$PYENV_ACTIVATE" != (pyenv prefix) ]
       if pyenv deactivate --no-error --verbose
+        set -e PYENV_DEACTIVATE
         pyenv activate --no-error --verbose; or set -e PYENV_DEACTIVATE
       else
         pyenv activate --no-error --verbose
@@ -110,19 +112,21 @@ esac
 if [[ "$shell" != "fish" ]]; then
   cat <<EOS
   if [ -n "\$PYENV_ACTIVATE" ]; then
-    if [ "x\`pyenv version-name\`" = "xsystem" ]; then
+    if [ "\$(pyenv version-name)" = "system" ]; then
       pyenv deactivate --no-error --verbose
+      unset PYENV_DEACTIVATE
       return 0
     fi
-    if [ "x\$PYENV_ACTIVATE" != "x\`pyenv prefix\`" ]; then
+    if [ "\$PYENV_ACTIVATE" != "\$(pyenv prefix)" ]; then
       if pyenv deactivate --no-error --verbose; then
+        unset PYENV_DEACTIVATE
         pyenv activate --no-error --verbose || unset PYENV_DEACTIVATE
       else
         pyenv activate --no-error --verbose
       fi
     fi
   else
-    if [ -z "\$VIRTUAL_ENV" ] && [ "x\$PYENV_DEACTIVATE" != "x\`pyenv prefix\`" ]; then
+    if [ -z "\$VIRTUAL_ENV" ] && [ "\$PYENV_DEACTIVATE" != "\$(pyenv prefix)" ]; then
       pyenv activate --no-error --verbose
     fi
   fi

test/activate.bats

@@ -24,7 +24,7 @@ setup() {
   assert_output <<EOS
 unset PYENV_DEACTIVATE;
 export PYENV_ACTIVATE="${PYENV_ROOT}/versions/venv";
-source "${PYENV_ROOT}/versions/venv/bin/activate";
+. "${PYENV_ROOT}/versions/venv/bin/activate";
 EOS
 }
 
@@ -46,7 +46,7 @@ EOS
 pyenv-virtualenv: activate venv
 unset PYENV_DEACTIVATE;
 export PYENV_ACTIVATE="${PYENV_ROOT}/versions/venv";
-source "${PYENV_ROOT}/versions/venv/bin/activate";
+. "${PYENV_ROOT}/versions/venv/bin/activate";
 EOS
 }
 
@@ -68,7 +68,7 @@ EOS
 pyenv shell "venv";
 unset PYENV_DEACTIVATE;
 export PYENV_ACTIVATE="${PYENV_ROOT}/versions/venv";
-source "${PYENV_ROOT}/versions/venv/bin/activate";
+. "${PYENV_ROOT}/versions/venv/bin/activate";
 EOS
 }
 
@@ -131,7 +131,7 @@ EOS
 pyenv shell "venv27";
 unset PYENV_DEACTIVATE;
 export PYENV_ACTIVATE="${PYENV_ROOT}/versions/venv27";
-source "${PYENV_ROOT}/versions/venv27/bin/activate";
+. "${PYENV_ROOT}/versions/venv27/bin/activate";
 EOS
 }
 
@@ -151,7 +151,7 @@ EOS
 pyenv shell "venv27";
 unset PYENV_DEACTIVATE;
 export PYENV_ACTIVATE="${PYENV_ROOT}/versions/venv27";
-source "${PYENV_ROOT}/versions/venv27/bin/activate";
+. "${PYENV_ROOT}/versions/venv27/bin/activate";
 EOS
 }
 

test/deactivate.bats

@@ -102,6 +102,25 @@ fi;
 EOS
 }
 
+@test "deactivate virtualenv which has been activated manually" {
+  export PYENV_VIRTUALENV_INIT=1
+  export VIRTUAL_ENV="${PYENV_ROOT}/versions/venv"
+
+  PYENV_SHELL="bash" run pyenv-sh-deactivate
+
+  assert_success
+  assert_output <<EOS
+if declare -f deactivate 1>/dev/null 2>&1; then
+  export PYENV_DEACTIVATE="$VIRTUAL_ENV";
+  unset PYENV_ACTIVATE;
+  deactivate;
+else
+  echo "pyenv-virtualenv: no virtualenv has been activated." 1>&2;
+  false;
+fi;
+EOS
+}
+
 @test "deactivate virtualenv (fish)" {
   export PYENV_VIRTUALENV_INIT=1
   export PYENV_ACTIVATE="${PYENV_ROOT}/versions/venv"
@@ -177,6 +196,26 @@ else;
 end;
 EOS
 }
+
+@test "deactivate virtualenv which has been activated manually (fish)" {
+  export PYENV_VIRTUALENV_INIT=1
+  export VIRTUAL_ENV="${PYENV_ROOT}/versions/venv"
+
+  PYENV_SHELL="fish" run pyenv-sh-deactivate
+
+  assert_success
+  assert_output <<EOS
+if functions -q deactivate;
+  setenv PYENV_DEACTIVATE "$VIRTUAL_ENV";
+  set -e PYENV_ACTIVATE;
+  deactivate;
+else;
+  echo "pyenv-virtualenv: no virtualenv has been activated." 1>&2;
+  false;
+end;
+EOS
+}
+
 @test "should fail if deactivate is invoked as a command" {
   run pyenv-deactivate
 

test/init.bats

@@ -32,19 +32,21 @@ load test_helper
 export PYENV_VIRTUALENV_INIT=1;
 _pyenv_virtualenv_hook() {
   if [ -n "\$PYENV_ACTIVATE" ]; then
-    if [ "x\`pyenv version-name\`" = "xsystem" ]; then
+    if [ "\$(pyenv version-name)" = "system" ]; then
       pyenv deactivate --no-error --verbose
+      unset PYENV_DEACTIVATE
       return 0
     fi
-    if [ "x\$PYENV_ACTIVATE" != "x\`pyenv prefix\`" ]; then
+    if [ "\$PYENV_ACTIVATE" != "\$(pyenv prefix)" ]; then
       if pyenv deactivate --no-error --verbose; then
+        unset PYENV_DEACTIVATE
         pyenv activate --no-error --verbose || unset PYENV_DEACTIVATE
       else
         pyenv activate --no-error --verbose
       fi
     fi
   else
-    if [ -z "\$VIRTUAL_ENV" ] && [ "x\$PYENV_DEACTIVATE" != "x\`pyenv prefix\`" ]; then
+    if [ -z "\$VIRTUAL_ENV" ] && [ "\$PYENV_DEACTIVATE" != "\$(pyenv prefix)" ]; then
       pyenv activate --no-error --verbose
     fi
   fi
@@ -64,10 +66,12 @@ function _pyenv_virtualenv_hook --on-event fish_prompt;
   if [ -n "\$PYENV_ACTIVATE" ]
     if [ (pyenv version-name) = "system" ]
       pyenv deactivate --no-error --verbose
+      set -e PYENV_DEACTIVATE
       return 0
     end
     if [ "\$PYENV_ACTIVATE" != (pyenv prefix) ]
       if pyenv deactivate --no-error --verbose
+        set -e PYENV_DEACTIVATE
         pyenv activate --no-error --verbose; or set -e PYENV_DEACTIVATE
       else
         pyenv activate --no-error --verbose
@@ -89,19 +93,21 @@ EOS
 export PYENV_VIRTUALENV_INIT=1;
 _pyenv_virtualenv_hook() {
   if [ -n "\$PYENV_ACTIVATE" ]; then
-    if [ "x\`pyenv version-name\`" = "xsystem" ]; then
+    if [ "\$(pyenv version-name)" = "system" ]; then
       pyenv deactivate --no-error --verbose
+      unset PYENV_DEACTIVATE
       return 0
     fi
-    if [ "x\$PYENV_ACTIVATE" != "x\`pyenv prefix\`" ]; then
+    if [ "\$PYENV_ACTIVATE" != "\$(pyenv prefix)" ]; then
       if pyenv deactivate --no-error --verbose; then
+        unset PYENV_DEACTIVATE
         pyenv activate --no-error --verbose || unset PYENV_DEACTIVATE
       else
         pyenv activate --no-error --verbose
       fi
     fi
   else
-    if [ -z "\$VIRTUAL_ENV" ] && [ "x\$PYENV_DEACTIVATE" != "x\`pyenv prefix\`" ]; then
+    if [ -z "\$VIRTUAL_ENV" ] && [ "\$PYENV_DEACTIVATE" != "\$(pyenv prefix)" ]; then
       pyenv activate --no-error --verbose
     fi
   fi

test/version.bats

@@ -4,7 +4,7 @@ load test_helper
 
 setup() {
   export PYENV_ROOT="${TMP}/pyenv"
-  export PYENV_VIRTUALENV_VERSION="20140705"
+  export PYENV_VIRTUALENV_VERSION="20141012"
 }
 
 @test "display virtualenv version" {

test/virtualenv.bats

@@ -132,3 +132,21 @@ OUT
   unstub pyenv-exec
   unstub curl
 }
+
+@test "no whitespace allowed in virtualenv name" {
+  run pyenv-virtualenv "3.2.1" "foo bar"
+
+  assert_failure
+  assert_output <<OUT
+pyenv-virtualenv: no whitespace allowed in virtualenv name.
+OUT
+}
+
+@test "no tab allowed in virtualenv name" {
+  run pyenv-virtualenv "3.2.1" "foo	bar baz"
+
+  assert_failure
+  assert_output <<OUT
+pyenv-virtualenv: no whitespace allowed in virtualenv name.
+OUT
+}