m/pyenv
1
0
Fork 0
mirror of https://github.com/pyenv/pyenv.git synced 2025-11-17 15:53:45 -05:00
Code Wiki Activity

reliably detect parent shell in rbenv init

Browse Source 
`$SHELL` variable is a terrible way of detecting the current shell
because it's not even supposed to reflect the current shell; it's meant
for keeping the value of the default shell for programs to start.

If an explicit `<shell>` argument wasn't passed to `rbenv init`, it
tries to detect the shell by getting the name of its parent process. If
this fails, it falls back on the value of `$SHELL` as before.

Furthermore, `rbenv init` will set the RBENV_SHELL variable in the
current shell to the value of the detected shell so that `sh-shell` and
`sh-rehash` commands don't have to repeat the detection.
This commit is contained in:
Mislav Marohnić
2013-09-28 18:43:39 +02:00
parent ff23666d56
commit 878bd87328
6 changed files with 34 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/shell.bats
View File

@@ -11,22 +11,22 @@ load test_helper
}
@test "shell version" {
SHELL=/bin/bash RBENV_VERSION="1.2.3" run rbenv-sh-shell
RBENV_SHELL=bash RBENV_VERSION="1.2.3" run rbenv-sh-shell
assert_success 'echo "$RBENV_VERSION"'
}
@test "shell version (fish)" {
SHELL=/usr/bin/fish RBENV_VERSION="1.2.3" run rbenv-sh-shell
RBENV_SHELL=fish RBENV_VERSION="1.2.3" run rbenv-sh-shell
assert_success 'echo "$RBENV_VERSION"'
}
@test "shell unset" {
SHELL=/bin/bash run rbenv-sh-shell --unset
RBENV_SHELL=bash run rbenv-sh-shell --unset
assert_success "unset RBENV_VERSION"
}
@test "shell unset (fish)" {
SHELL=/usr/bin/fish run rbenv-sh-shell --unset
RBENV_SHELL=fish run rbenv-sh-shell --unset
assert_success "set -e RBENV_VERSION"
}
@@ -41,12 +41,12 @@ SH
@test "shell change version" {
mkdir -p "${RBENV_ROOT}/versions/1.2.3"
SHELL=/bin/bash run rbenv-sh-shell 1.2.3
RBENV_SHELL=bash run rbenv-sh-shell 1.2.3
assert_success 'export RBENV_VERSION="1.2.3"'
}
@test "shell change version (fish)" {
mkdir -p "${RBENV_ROOT}/versions/1.2.3"
SHELL=/usr/bin/fish run rbenv-sh-shell 1.2.3
RBENV_SHELL=fish run rbenv-sh-shell 1.2.3
assert_success 'setenv RBENV_VERSION "1.2.3"'
}